Added IE 187(Maximum Wait Time) and 188(Millisecond Time Stamp) to gtp_v2.py #4376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4376 +/- ##
==========================================
- Coverage 82.21% 78.72% -3.50%
==========================================
Files 353 334 -19
Lines 83586 81044 -2542
==========================================
- Hits 68723 63802 -4921
- Misses 14863 17242 +2379
|
|
Thanks for the PR ! Could you add a unit test that builds and/or dissects those new packets? |
Is there anywhere that shows how to build the test? |
|
You can read the doc: https://scapy.readthedocs.io/en/latest/development.html#testing-with-utscapy but the format is trivial to understand. You can add them to: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds to the GTPv2 protocol capability of Scapy by adding support for the Information Elements 187(Maximum Wait Time) and 188(Millisecond Time Stamp).